[CMake] add support for find_package#10097
Merged
jroesch merged 4 commits intoapache:mainfrom Feb 17, 2022
Merged
Conversation
2. added cmake package config file
Member
|
cc @tkonolige can you take a look at this one? |
tkonolige
requested changes
Feb 8, 2022
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
Thank you @prateek9623 for this PR. It really helps improve the usability of tvm by other projects.
One issue though: the exported config file needs to find_package(Threads REQUIRED) as it is a PUBLIC dependency of tvm.
Contributor
Author
|
@tkonolige I have Threads as the public dependency, and as per PROJECT_CONFIG_FILE it is just to create a temporary file, its content is just moved in line no: Line 655 in dc0550e |
Contributor
Author
|
@tkonolige done with requested changes |
tkonolige
approved these changes
Feb 10, 2022
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
Looks good, thank you @prateek9623!
jroesch
approved these changes
Feb 17, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* removed include header path, which are invalid * 1. added target tvm in a cmake export group 2. added cmake package config file * added Threads as public dependency * changed temp config file name for better understanding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following features: