[ci] Invoke tensorflow tests individually#10198
Merged
masahi merged 2 commits intoapache:mainfrom Feb 10, 2022
driazati:tensorflow2
Merged
[ci] Invoke tensorflow tests individually#10198masahi merged 2 commits intoapache:mainfrom driazati:tensorflow2
masahi merged 2 commits intoapache:mainfrom
driazati:tensorflow2
Conversation
driazati
changed the title
masahi
pushed a commit
that referenced
this pull request
Feb 10, 2022
This should resolve the issue posted here https://discuss.tvm.apache.org/t/tensorflow-2-0-test-failures-while-running-the-tensor-flow-frontend-test-forward-py-function/11322 based on [this comment](https://discuss.tvm.apache.org/t/tensorflow-2-0-test-failures-while-running-the-tensor-flow-frontend-test-forward-py-function/11322/3?u=driazati). This is a necessary precursor to #10198 since it relies on invoking the tests individually. Co-authored-by: driazati <driazati@users.noreply.github.com>
This is another (simpler) attempt at #10151 to avoid CUDA issues with tensorflow tests. This should work by cleaning up any reserved GPU memory by tearing down the whole process that has imported tensorflow each time a test is run.
Copy of #10197 but using a pytest plugin instead of manually grepping through test files
driazati
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
masahi
approved these changes
Feb 10, 2022
mbrookhart
approved these changes
Feb 10, 2022
alnah005
pushed a commit
to alnah005/tvm
that referenced
this pull request
Feb 10, 2022
* [ci] Invoke tensorflow tests individually This is another (simpler) attempt at apache#10151 to avoid CUDA issues with tensorflow tests. This should work by cleaning up any reserved GPU memory by tearing down the whole process that has imported tensorflow each time a test is run. * [ci] Invoke tensorflow tests individually Copy of apache#10197 but using a pytest plugin instead of manually grepping through test files Co-authored-by: driazati <driazati@users.noreply.github.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
This should resolve the issue posted here https://discuss.tvm.apache.org/t/tensorflow-2-0-test-failures-while-running-the-tensor-flow-frontend-test-forward-py-function/11322 based on [this comment](https://discuss.tvm.apache.org/t/tensorflow-2-0-test-failures-while-running-the-tensor-flow-frontend-test-forward-py-function/11322/3?u=driazati). This is a necessary precursor to apache#10198 since it relies on invoking the tests individually. Co-authored-by: driazati <driazati@users.noreply.github.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* [ci] Invoke tensorflow tests individually This is another (simpler) attempt at apache#10151 to avoid CUDA issues with tensorflow tests. This should work by cleaning up any reserved GPU memory by tearing down the whole process that has imported tensorflow each time a test is run. * [ci] Invoke tensorflow tests individually Copy of apache#10197 but using a pytest plugin instead of manually grepping through test files Co-authored-by: driazati <driazati@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This loops through and invokes all the tensorflow tests individually rather than in a single Python process. This should have the OS clean up tensorflow's CPU/GPU memory usage between each test and reduce flakiness, at the cost of some runtime overhead (which we could maybe remove in the future with some caching inside pytest, but it's small compared to the test time)
cc @areusch @mbrookhart @masahi