Skip to content

[Bugfix] Added definition for constexpr char* PoolInfo variables. #10272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lunderberg wants to merge 1 commit into from
Closed

[Bugfix] Added definition for constexpr char* PoolInfo variables. #10272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/ir/memory_pools.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@

namespace tvm {

// In C++14, even though these are declared as static constexpr and
// have a value defined in the class definition, they must still have
// a declaration in a compilation unit. This defect is fixed in
// C++17, but since TVM currently targets C++14, these declarations
// are required.
//
// See https://stackoverflow.com/a/28846608 for more details.
constexpr const char* PoolInfo::kTargetPoolReadOnlyAccess;
constexpr const char* PoolInfo::kTargetPoolReadWriteAccess;

PoolInfo::PoolInfo(String pool_name, Map<Target, String> target_access, Integer size_hint_bytes,
Integer clock_frequency_hz, Integer read_bandwidth_bytes_per_cycle,
Integer write_bandwidth_bytes_per_cycle, Integer read_latency_cycles,
Expand Down