Fixed a bug in the convert_fully_connected() function#10371
Merged
leandron merged 1 commit intoapache:mainfrom Feb 28, 2022
Merged
Fixed a bug in the convert_fully_connected() function#10371leandron merged 1 commit intoapache:mainfrom
leandron merged 1 commit intoapache:mainfrom
Conversation
ophirfrish
requested review from
Huyuwei,
jwfromm,
kazum,
mbrookhart,
siju-samuel and
srkreddy1238
as code owners
In case we need to change the output shape, need to convert the output_shape tuple to list before the change.
ophirfrish
force-pushed
the
tvmc-tuple-fix
branch
from
301df5d to
9973008
Compare
leandron
approved these changes
Feb 28, 2022
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
LGTM, thanks @ophirfrish!
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
In case we need to change the output shape, need to convert the output_shape tuple to list before the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case we need to change the output shape, need to convert the output_shape tuple to list before the change.
cc @areusch @leandron @Mousius @gromero for reviews