Correctly enable architecture extensions in CMSIS-NN Zephyr Demo#10458
Merged
manupak merged 2 commits intoapache:mainfrom Mar 4, 2022
Merged
Correctly enable architecture extensions in CMSIS-NN Zephyr Demo#10458manupak merged 2 commits intoapache:mainfrom
manupak merged 2 commits intoapache:mainfrom
Conversation
Without `CONFIG_FPU` being set the correct architecture extensions weren't being applied which means the buffer sizes didn't necessarily match up - this corrects it so that they align.
Mousius
requested review from
comaniac,
icemelon,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
The stack allocator forcibly aligns memory by removing parts of it which causes there not to be enough memory and the CMSIS-NN integration uses more stack than the demo with pure TVM operators (we should look to remove some of our stack usage)
Mousius
force-pushed
the
cmsis-demo-fixes
branch
from
757d4a1 to
da18936
Compare
manupak
approved these changes
Mar 4, 2022
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
LGTM! oh we haven't aligned it before. have we ? -- this make sense!
Contributor
|
Thanks @Mousius ! |
Member
Author
Nope, the allocators behaviour is to try to fix it rather than producing an error so it instead fails at the allocate - which lead me to assume it was a miscalculation, it all makes sense now 😸 . |
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
…che#10458) * Correctly enable architecture extensions in CMSIS-NN Zephyr Demo Without `CONFIG_FPU` being set the correct architecture extensions weren't being applied which means the buffer sizes didn't necessarily match up - this corrects it so that they align. * Fix memory allocation in demo The stack allocator forcibly aligns memory by removing parts of it which causes there not to be enough memory and the CMSIS-NN integration uses more stack than the demo with pure TVM operators (we should look to remove some of our stack usage)
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…che#10458) * Correctly enable architecture extensions in CMSIS-NN Zephyr Demo Without `CONFIG_FPU` being set the correct architecture extensions weren't being applied which means the buffer sizes didn't necessarily match up - this corrects it so that they align. * Fix memory allocation in demo The stack allocator forcibly aligns memory by removing parts of it which causes there not to be enough memory and the CMSIS-NN integration uses more stack than the demo with pure TVM operators (we should look to remove some of our stack usage)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
CONFIG_FPUbeing set the correct architecture extensions weren't being applied which means the buffer sizes didn't necessarily match up - this corrects it so that they align.