Skip to content

Comments

[relay] Changed 'name' field to 'registry_name' for Executor and Runtime#10466

Merged
areusch merged 5 commits intoapache:mainfrom
d-smirnov:executor_name
Jul 11, 2022
Merged

[relay] Changed 'name' field to 'registry_name' for Executor and Runtime#10466
areusch merged 5 commits intoapache:mainfrom
d-smirnov:executor_name

Conversation

@d-smirnov
Copy link
Contributor

@d-smirnov d-smirnov commented Mar 3, 2022

Changed 'name' field to 'registry_name' for Executor and Runtime python
wrappers as it clashed with tvm object attribute 'name' which made the latter
inaccessible from Python

@d-smirnov d-smirnov force-pushed the executor_name branch 2 times, most recently from 31dee0e to 99cfbde Compare March 3, 2022 21:34
@d-smirnov d-smirnov requested a review from leandron as a code owner March 3, 2022 21:34
@d-smirnov d-smirnov changed the title [relay] Removed extra 'name' field from Executor [relay] Changed 'name' field to 'registry_name' for Executor and Runtime Mar 3, 2022
@d-smirnov
Copy link
Contributor Author

cc: @Mousius

@areusch
Copy link
Contributor

areusch commented Apr 11, 2022

LGTM, @Mousius do you wanna take a look?

Changed 'name' field to 'registry_name' for Executor and Runtime python
wrappers as it clashed with tvm object attribute 'name' which made the latter
inaccessible from Python

Change-Id: I917755753549edfe1d3090ca9ca4512de552c4bd

changed name to registry_name

Change-Id: I9feb5b33b7b6f6f8421902e5721167f585cc4193
Change-Id: Ie2e96297fda119e1b726b196a59deae95b263a07
Change-Id: Id579c50ab58dfb25fa18436265e0701ebbd9d554
Change-Id: Iabbd81069959f05c073f9dbc8d10fb31dd05f7a3
@d-smirnov d-smirnov requested a review from areusch July 6, 2022 08:13
@areusch areusch merged commit 7baf4be into apache:main Jul 11, 2022
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
…ime (apache#10466)

* [relay] Changed Executor and Runtime 'name' field to 'registry_name'

Changed 'name' field to 'registry_name' for Executor and Runtime python
wrappers as it clashed with tvm object attribute 'name' which made the latter
inaccessible from Python

Change-Id: I917755753549edfe1d3090ca9ca4512de552c4bd

changed name to registry_name

Change-Id: I9feb5b33b7b6f6f8421902e5721167f585cc4193

* more fixed unit tests

Change-Id: Ie2e96297fda119e1b726b196a59deae95b263a07

* typo fixed

Change-Id: Id579c50ab58dfb25fa18436265e0701ebbd9d554

* renamed registry_name to flag_registry_name

Change-Id: Iabbd81069959f05c073f9dbc8d10fb31dd05f7a3

* bugfix
junrushao pushed a commit to yelite/tvm that referenced this pull request Jul 27, 2022
…ime (apache#10466)

* [relay] Changed Executor and Runtime 'name' field to 'registry_name'

Changed 'name' field to 'registry_name' for Executor and Runtime python
wrappers as it clashed with tvm object attribute 'name' which made the latter
inaccessible from Python

Change-Id: I917755753549edfe1d3090ca9ca4512de552c4bd

changed name to registry_name

Change-Id: I9feb5b33b7b6f6f8421902e5721167f585cc4193

* more fixed unit tests

Change-Id: Ie2e96297fda119e1b726b196a59deae95b263a07

* typo fixed

Change-Id: Id579c50ab58dfb25fa18436265e0701ebbd9d554

* renamed registry_name to flag_registry_name

Change-Id: Iabbd81069959f05c073f9dbc8d10fb31dd05f7a3

* bugfix
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…ime (apache#10466)

* [relay] Changed Executor and Runtime 'name' field to 'registry_name'

Changed 'name' field to 'registry_name' for Executor and Runtime python
wrappers as it clashed with tvm object attribute 'name' which made the latter
inaccessible from Python

Change-Id: I917755753549edfe1d3090ca9ca4512de552c4bd

changed name to registry_name

Change-Id: I9feb5b33b7b6f6f8421902e5721167f585cc4193

* more fixed unit tests

Change-Id: Ie2e96297fda119e1b726b196a59deae95b263a07

* typo fixed

Change-Id: Id579c50ab58dfb25fa18436265e0701ebbd9d554

* renamed registry_name to flag_registry_name

Change-Id: Iabbd81069959f05c073f9dbc8d10fb31dd05f7a3

* bugfix
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
…ime (apache#10466)

* [relay] Changed Executor and Runtime 'name' field to 'registry_name'

Changed 'name' field to 'registry_name' for Executor and Runtime python
wrappers as it clashed with tvm object attribute 'name' which made the latter
inaccessible from Python

Change-Id: I917755753549edfe1d3090ca9ca4512de552c4bd

changed name to registry_name

Change-Id: I9feb5b33b7b6f6f8421902e5721167f585cc4193

* more fixed unit tests

Change-Id: Ie2e96297fda119e1b726b196a59deae95b263a07

* typo fixed

Change-Id: Id579c50ab58dfb25fa18436265e0701ebbd9d554

* renamed registry_name to flag_registry_name

Change-Id: Iabbd81069959f05c073f9dbc8d10fb31dd05f7a3

* bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants