Add missing Slice layout fallback check of stride=1.#10690
Merged
masahi merged 4 commits intoapache:mainfrom Mar 24, 2022
Merged
Add missing Slice layout fallback check of stride=1.#10690masahi merged 4 commits intoapache:mainfrom
stride=1.#10690masahi merged 4 commits intoapache:mainfrom
Conversation
stride=1.
Member
|
The CI is having an flaky issue with |
Contributor
Author
|
Not sure what is going on with the CI. I thought my previous commit was stuck at some stage but now I saw a check there, but still I saw |
masahi
approved these changes
Mar 24, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* Add missing Slice layout fallback check. * Fix lint * jostle ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing layout optimization for slice, if
startorendare divisibly by the pack factor andstride=1, alayout_transformcan be saved. However, previous code only checksstride=1whenaxesis not specified, as intvm/src/relay/op/tensor/transform.cc
Lines 2735 to 2741 in 2fc7d16
The following model can trigger this bug with error message
...In particular `Tensor[(4, 1, 1, 1), float32]` does not match `Tensor[(4, 3, 1, 1), float32]`.cc @masahi