Skip to content

[AOT] Get input name from module/prim func#10731

Merged
areusch merged 1 commit intoapache:mainfrom
lhutton1:fix-aot-tests
Mar 23, 2022
Merged

[AOT] Get input name from module/prim func#10731
areusch merged 1 commit intoapache:mainfrom
lhutton1:fix-aot-tests

Conversation

@lhutton1
Copy link
Contributor

The input name generated in each of these test cases changes depending on the version of tensorflow being used. v2.4 = "x_int8", while v2.6 = "x". Making these tests agnostic of input name so that they work with both v2.4 and v2.6.

cc @leandron @Mousius @grant-arm

The input name generated in each of these test cases changes depending
on the version of tensorflow being used. v2.4 = "x_int8", while v2.6
= "x". Making these tests agnostic of input name so that they work with
both v2.4 and v2.6.

Change-Id: I843a655b3bf4e018624e5757c653b1d85058991e
@github-actions github-actions bot requested review from Mousius and leandron March 23, 2022 17:32
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lhutton1!

@areusch areusch merged commit 7ffc0fc into apache:main Mar 23, 2022
@lhutton1 lhutton1 deleted the fix-aot-tests branch March 24, 2022 19:07
Mousius added a commit to Mousius/tvm that referenced this pull request Apr 1, 2022
This was fixed in apache#10731 as it was the mismatch of tensorflow versions in use by the different CI containers.
kparzysz-quic pushed a commit that referenced this pull request Apr 1, 2022
This was fixed in #10731 as it was the mismatch of tensorflow versions in use by the different CI containers.
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
The input name generated in each of these test cases changes depending
on the version of tensorflow being used. v2.4 = "x_int8", while v2.6
= "x". Making these tests agnostic of input name so that they work with
both v2.4 and v2.6.

Change-Id: I843a655b3bf4e018624e5757c653b1d85058991e
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
This was fixed in apache#10731 as it was the mismatch of tensorflow versions in use by the different CI containers.
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
This was fixed in apache#10731 as it was the mismatch of tensorflow versions in use by the different CI containers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants