[runtime-hexagon-rpc] more Hexagon/Android logging#10767
Merged
masahi merged 1 commit intoapache:mainfrom Apr 4, 2022
Merged
Conversation
Contributor
Author
Member
|
@cconvey In the case of multiple tags, it would be great to use them in separate brackets: |
kparzysz-quic
approved these changes
Mar 24, 2022
Contributor
Author
IIUC there's a plan to tweak the guidelines for these in a few weeks, and so current practices are rather ac hoc. So if there are not serious objections I'm going to leave this as-is for now. |
Contributor
Author
|
@kparzysz-quic : Mind merging this? |
Contributor
|
I can merge it, but it needs to pass the CI first. I think you need to rebase, push an empty commit to restart the build. |
- Alter `android_bash.sh` to meet the runtime conditions needed for FARF logging. (Note that FARF logging is also governed by certain preprocessor definitions.) - Alter `android_bash.sh` so that any stdout/stderr emitted by `tvm_rpc_android_server` is saved to a log file (`tvm_rpc_android.log`). Previously that output was simply lost.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
- Alter `android_bash.sh` to meet the runtime conditions needed for FARF logging. (Note that FARF logging is also governed by certain preprocessor definitions.) - Alter `android_bash.sh` so that any stdout/stderr emitted by `tvm_rpc_android_server` is saved to a log file (`tvm_rpc_android.log`). Previously that output was simply lost.
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
- Alter `android_bash.sh` to meet the runtime conditions needed for FARF logging. (Note that FARF logging is also governed by certain preprocessor definitions.) - Alter `android_bash.sh` so that any stdout/stderr emitted by `tvm_rpc_android_server` is saved to a log file (`tvm_rpc_android.log`). Previously that output was simply lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alter
android_bash.shto meet the runtime conditions neededfor FARF logging. (Note that FARF logging is also governed
by certain preprocessor definitions.)
Alter
android_bash.shso that any stdout/stderr emittedby
tvm_rpc_android_serveris saved to a log file(
tvm_rpc_android.log). Previously that output was simplylost.