[Pass] Fix printer formatting for PassInfo#10844
Merged
AndrewZhaoLuo merged 2 commits intoapache:mainfrom Apr 1, 2022
Merged
Conversation
The format of the printed PassInfoNode was difficult to read as there was no separation between the different attributes of the node Before this change, PassInfo is printed as: The meta data of the pass: pass name: tir.ApplyLayoutTransformsopt_level: 0required passes: [ ] After this change, PassInfo is printed as: The meta data of the pass - pass name: tir.ApplyLayoutTransforms, opt_level: 0, required passes: []
quic-sanirudh
force-pushed
the
passinfo_printing
branch
from
0a1c06a to
4b25b72
Compare
AndrewZhaoLuo
approved these changes
Apr 1, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [Pass] Fix printer formatting for PassInfo The format of the printed PassInfoNode was difficult to read as there was no separation between the different attributes of the node Before this change, PassInfo is printed as: The meta data of the pass: pass name: tir.ApplyLayoutTransformsopt_level: 0required passes: [ ] After this change, PassInfo is printed as: The meta data of the pass - pass name: tir.ApplyLayoutTransforms, opt_level: 0, required passes: [] * Restart CI
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
* [Pass] Fix printer formatting for PassInfo The format of the printed PassInfoNode was difficult to read as there was no separation between the different attributes of the node Before this change, PassInfo is printed as: The meta data of the pass: pass name: tir.ApplyLayoutTransformsopt_level: 0required passes: [ ] After this change, PassInfo is printed as: The meta data of the pass - pass name: tir.ApplyLayoutTransforms, opt_level: 0, required passes: [] * Restart CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format of the printed PassInfoNode was difficult to read as there
was no separation between the different attributes of the node
Before this change, PassInfo is printed as:
After this change, PassInfo is printed as: