Fix an apparent bug in the [web] timer.#10875
Merged
kparzysz-quic merged 2 commits intoapache:mainfrom Apr 2, 2022
Merged
Conversation
AndrewZhaoLuo
approved these changes
Apr 1, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've never worked in TypeScript before, so it's possible I'm wrong, but the behavior of this timer script appears to be inconsistent with the earlier(?) code in tvm/src/runtime/rpc/rpc_module.cc#L387-388.
As far as I can tell, what this code is supposed to be doing is scaling up the number of runs measured per trial if minRepeatMs hasn't been reached. The
maxcondition seems to be intended to make sure that the number of replicates run on subsequent trials is no less than 1.618 times the previous attempt's trials -- presumably as a failsafe against somehow getting stuck in a very tight loop. The version of the code in web/src/runtime.ts wouldn't actually avoid that problem, though.