[QNN] Fix qnn.dequantize scale and zp shape#10880
Merged
AndrewZhaoLuo merged 3 commits intoapache:mainfrom Apr 5, 2022
Merged
Conversation
Contributor
Author
AndrewZhaoLuo
requested changes
Apr 4, 2022
sfvaroglu
force-pushed
the
sevin/dq_shape
branch
from
15bdf77 to
5c0e305
Compare
mbrookhart
approved these changes
Apr 5, 2022
AndrewZhaoLuo
approved these changes
Apr 5, 2022
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
LGTM, just some nits.
Contributor
|
PTAL @sfvaroglu |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [QNN] Fix qnn.dequantize scale and zp shape * Rework * Add review feedback
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
* [QNN] Fix qnn.dequantize scale and zp shape * Rework * Add review feedback
Lucien0
pushed a commit
to Lucien0/tvm
that referenced
this pull request
Apr 19, 2022
* [QNN] Fix qnn.dequantize scale and zp shape * Rework * Add review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type checker fails with:
This PR provides a fix.