[Hexagon] Handle TCP server binding to unknown port#10945
[Hexagon] Handle TCP server binding to unknown port#10945mehrdadh merged 1 commit intoapache:mainfrom kparzysz-quic:hexagon-rpc-server-port
Conversation
The server IP address will be obtained from the RPC tracker, but multiple servers must be distinguishable. To enable this, set a unique key when starting a server, and use that key when starting a session.
|
To add more context here: the RPC server will connect to a first available port in some range (which typically starts at 7070). If there are two servers running on the same machine, one of them will get 7070, and the other 7071. The clients will not know the actual port, instead they will query the RPC tracker for a server with a given device key. Since the Hexagon RPC server always used the same key, the tracker could not distinguish between the one bound to 7070, and the one bound to 7071. To avoid this ambiguity, make the device key unique (by attaching the PID of the process creating it to it). |
|
cc: @masahi |
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
Overall LGTM, only one comment about setting the default key
| } | ||
| self._rpc_info.update(rpc_info) | ||
| self._workspace = self._create_workspace(workspace) | ||
| self._device_key = self.HEXAGON_REMOTE_DEVICE_KEY |
There was a problem hiding this comment.
wouldn't this always set the key to be self.HEXAGON_REMOTE_DEVICE_KEY? My understanding is that the goal is to be able to set the key to distinguish RPC server between different tests/runs?
There was a problem hiding this comment.
You're right: the idea is to get the PID of the process that starts the server. The launcher itself may be created once ahead of time, and then we'd have the same PID for every server. Since the base class only has an abstract method start_server, the appending of the PID is done in the actual implementations. I'm setting the member _device_key, here so that it exists in the object.
At the moment, the PID is only appended for the simulator. Do you think we should do that for Android as well?
There was a problem hiding this comment.
Do you have any additional comments? Should I add this for Android as well, or is it ok as it is?
There was a problem hiding this comment.
This is okay as it is. Not sure if this could solve some of the existing issues with test flakiness on Android. We can consider it later.
The server IP address will be obtained from the RPC tracker, but multiple servers must be distinguishable. To enable this, set a unique key when starting a server, and use that key when starting a session.
The server IP address will be obtained from the RPC tracker, but multiple servers must be distinguishable. To enable this, set a unique key when starting a server, and use that key when starting a session.
2 participants
The server IP address will be obtained from the RPC tracker, but multiple servers must be distinguishable. To enable this, set a unique key when starting a server, and use that key when starting a session.
cc @mehrdadh