[QNN] Support input scale and zp of 1-element vector in qnn.conv2d_transpose#10952
Merged
AndrewZhaoLuo merged 2 commits intoapache:mainfrom Apr 20, 2022
Merged
Conversation
Contributor
Author
|
@AndrewZhaoLuo @anwang2009 please review |
AndrewZhaoLuo
requested changes
Apr 12, 2022
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
Hmm curious your thoughts. One more comment, please rebase too.
sfvaroglu
force-pushed
the
sevin/qnn_conv2d_transpose_shape
branch
from
759555d to
3c12438
Compare
AndrewZhaoLuo
approved these changes
Apr 18, 2022
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
LGTM, need to read more into broadcasting conventions in TVM
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
…anspose (apache#10952) * Support input scale and zp of 1-element vector in qnn.conv2d_transpose * Lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing some models with 1-element vectors for input_scale and input_zero_point in
qnn.conv2d_transpose. This PR adds support to handle those shapes.