[TVMC] Add configuration json files to the Python package#11063
Merged
Mousius merged 1 commit intoapache:mainfrom Apr 20, 2022
Merged
[TVMC] Add configuration json files to the Python package#11063Mousius merged 1 commit intoapache:mainfrom
Mousius merged 1 commit intoapache:mainfrom
Conversation
Mousius
approved these changes
Apr 19, 2022
Member
Mousius
left a comment
Mousius
left a comment
There was a problem hiding this comment.
LGTM! I wheely think we should land this to fix the wheels.
NicolaLancellotti
approved these changes
Apr 20, 2022
Mousius
requested changes
Apr 20, 2022
leandron
force-pushed
the
config_json_package
branch
from
0a604e7 to
bde1d41
Compare
Add the `configs` directory to be part of the installed version of TVM in the setuptools configuration, and introduce a new function to load the `configs` directory from the right paths both when TVM is locally installed for development, as well as, when it is installed as a package.
leandron
force-pushed
the
config_json_package
branch
from
bde1d41 to
04ecb67
Compare
Member
|
Wheely appreciate the fix @leandron ! |
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
Add the `configs` directory to be part of the installed version of TVM in the setuptools configuration, and introduce a new function to load the `configs` directory from the right paths both when TVM is locally installed for development, as well as, when it is installed as a package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
configsdirectory to be part of the installed version of TVM in the setuptools configuration, and introduce a new function to load theconfigsdirectory from the right paths both when TVM is locally installed for development, as well as, when it is installed as a package.This builds on top of #11012, just adding support for the files to be added in the package. More testing needs to be added (planning for that in future patches) to support some system testing of the packaged version of TVM.
cc @Mousius @gromero @areusch for reviews