Skip to content

[Auto Scheduler]add task name during printing table info#11098

Merged
masahi merged 5 commits intoapache:mainfrom
shingjan:auto_schedler_add_task_name_print_info
Apr 23, 2022
Merged

[Auto Scheduler]add task name during printing table info#11098
masahi merged 5 commits intoapache:mainfrom
shingjan:auto_schedler_add_task_name_print_info

Conversation

@shingjan
Copy link

@shingjan shingjan commented Apr 22, 2022

This PR intends to add task name within the PrintTableInfo callback function of auto_scheduler to improve the readability of related logs.

Behavior of PrintTableInfo before this change:

|  ID  | Latency (ms) | Speed (GFLOPS) | Trials |
-------------------------------------------------
|    0 |   100000.000 |           0.00 |      0 |
|    1 |        0.000 |          12.80 |      0 |

After

|  ID  |                       Task Description                        | Latency (ms) | Speed (GFLOPS) | Trials |
-----------------------------------------------------------------------------------------------------------------
|    0 |                          vm_mod_fused_nn_conv2d_add_nn_relu_2 |   100000.000 |           0.00 |      0 |
|    1 |                          vm_mod_fused_nn_conv2d_add_nn_relu_4 |        0.000 |          12.80 |      0 |

cc: @zxybazh @junrushao1994

@junrushao
Copy link
Member

Might need some tweak arounds aesthetically but sure I like this change :-)

CC @Hzfengsy @merrymercy

@comaniac
Copy link
Contributor

Overall LGTM. One miner suggestion is using "desc" instead of "name" to align with the attribute name. After all this is not an official task name but just a human readable hint.

Copy link
Member

@Hzfengsy Hzfengsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxybazh
Copy link
Member

zxybazh commented Apr 22, 2022

Thanks for the contribution! Could you please fix the CI and also attach an example of the printed table in the introduction?

@shingjan shingjan marked this pull request as ready for review April 22, 2022 19:59
@masahi masahi merged commit 60e43e1 into apache:main Apr 23, 2022
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
* add task name during printing table info

* address comments and fix lint

* better look

* fix linting

* fix linting again
@shingjan shingjan deleted the auto_schedler_add_task_name_print_info branch July 5, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants