[Auto Scheduler]add task name during printing table info#11098
Merged
masahi merged 5 commits intoapache:mainfrom Apr 23, 2022
Merged
[Auto Scheduler]add task name during printing table info#11098masahi merged 5 commits intoapache:mainfrom
masahi merged 5 commits intoapache:mainfrom
Conversation
Member
|
Might need some tweak arounds aesthetically but sure I like this change :-) |
Contributor
|
Overall LGTM. One miner suggestion is using "desc" instead of "name" to align with the attribute name. After all this is not an official task name but just a human readable hint. |
Member
|
Thanks for the contribution! Could you please fix the CI and also attach an example of the printed table in the introduction? |
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
* add task name during printing table info * address comments and fix lint * better look * fix linting * fix linting again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to add task name within the
PrintTableInfocallback function ofauto_schedulerto improve the readability of related logs.Behavior of
PrintTableInfobefore this change:After
cc: @zxybazh @junrushao1994