[arith] Simplify the output of InverseAffineIterMap#11167
Merged
junrushao merged 2 commits intoapache:mainfrom Apr 29, 2022
Merged
[arith] Simplify the output of InverseAffineIterMap#11167junrushao merged 2 commits intoapache:mainfrom
junrushao merged 2 commits intoapache:mainfrom
Conversation
junrushao
reviewed
Apr 28, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Thanks for spotting this case!
junrushao
approved these changes
Apr 28, 2022
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
This PR simplifies the result of `InverseAffineIterMap` by assuming the `output` param has the same range as the output range of the affine transformation. For example, for iter map `i, j => i * 16 + j, i \in [0, 8), j \in [0, 16)`, after this PR, the inverse will be `m => m // 16, m % 16, m \in [0, 128)` instead of `m => (m // 16) % 8, m % 16`
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
This PR simplifies the result of `InverseAffineIterMap` by assuming the `output` param has the same range as the output range of the affine transformation. For example, for iter map `i, j => i * 16 + j, i \in [0, 8), j \in [0, 16)`, after this PR, the inverse will be `m => m // 16, m % 16, m \in [0, 128)` instead of `m => (m // 16) % 8, m % 16`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the result of
InverseAffineIterMapby assuming theoutputparam has the same range as the output range of the affine transformation. For example, for iter mapi, j => i * 16 + j, i \in [0, 8), j \in [0, 16), after this PR, the inverse will bem => m // 16, m % 16, m \in [0, 128)instead ofm => (m // 16) % 8, m % 16cc @spectrometerHBH @junrushao1994