Canonicalize type annotation during construction of Var and SizeVar#11443
Merged
tqchen merged 4 commits intoapache:mainfrom May 30, 2022
Merged
Canonicalize type annotation during construction of Var and SizeVar#11443tqchen merged 4 commits intoapache:mainfrom
tqchen merged 4 commits intoapache:mainfrom
Conversation
junrushao
reviewed
May 25, 2022
Member
|
Looks like unittests are failing because of this |
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
tqchen
approved these changes
May 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
var->type_annotation may be empty when only
runtime::DataTypeis passed to the constructor. This PR added canonicalization during the construction ofVarandSizeVar, so thatVar(dtype="float32", type_annotation=PrimType(Float(32)))is equivalent toVar(dtype="float32", type_annotation=None).The printer side for
VarandSizeVaris not affected and doesn't need update.ReprPrinteralways omit type information: https://github.com/apache/tvm/blob/main/src/tir/ir/expr.cc#L120TextPrinterhas already been implicitly converting fromruntime::DataTypetoType: https://github.com/apache/tvm/blob/main/src/printer/tir_text_printer.cc#L782cc @tqchen