Skip to content

[microNPU] Fix offloading incompatible average pool#11469

Merged
manupak merged 1 commit intoapache:mainfrom
lhutton1:fix-avg-pool-offload
Jun 30, 2022
Merged

[microNPU] Fix offloading incompatible average pool#11469
manupak merged 1 commit intoapache:mainfrom
lhutton1:fix-avg-pool-offload

Conversation

@lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented May 26, 2022

Fixes offloading a few corner cases of average pooling. Specifically not offloading nn.avg_pool2d when:

  • The attribute count_include_pad=True
  • Padding exceeds the dimensions [3, 3, 4, 4]
  • The pool size is greater than [8, 8] when the pool uses padding

cc @Mousius @NicolaLancellotti @ekalda @manupa-arm

@github-actions github-actions bot requested a review from manupak May 26, 2022 13:39
@lhutton1 lhutton1 force-pushed the fix-avg-pool-offload branch from 677e7c2 to 1accdee Compare May 26, 2022 16:49
@github-actions github-actions bot requested a review from Mousius May 26, 2022 16:49
Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhutton1 for fixing this!

@lhutton1
Copy link
Contributor Author

@tvm-bot rerun

2 similar comments
@lhutton1
Copy link
Contributor Author

@tvm-bot rerun

@lhutton1
Copy link
Contributor Author

@tvm-bot rerun

@lhutton1 lhutton1 force-pushed the fix-avg-pool-offload branch 3 times, most recently from 1368ce4 to dcff5ed Compare June 29, 2022 12:30
Fixes offloading a few corner cases of average pooling. Specifically
not offloading nn.avg_pool2d when:
* The attribute count_include_pad=True
* Padding exceeds the dimensions [3, 3, 4, 4]
* The pool size is greater than [8, 8] when the pool uses padding

Change-Id: I7be546e28ebe1f17482f3ed3cee56996a71bfcd1
@lhutton1 lhutton1 force-pushed the fix-avg-pool-offload branch from dcff5ed to 88cef62 Compare June 30, 2022 08:26
@lhutton1
Copy link
Contributor Author

This is finally green :)

@manupak
Copy link
Contributor

manupak commented Jun 30, 2022

Might be better to add a test for to cover this case.
(Happy to take a follow-up)

@lhutton1
Copy link
Contributor Author

Sure! Might be best to do in a follow up (CI seems quite flaky atm)

@manupak manupak merged commit 80a0c6c into apache:main Jun 30, 2022
@manupak
Copy link
Contributor

manupak commented Jun 30, 2022

Thanks @ekalda @lhutton1 !

@lhutton1 lhutton1 deleted the fix-avg-pool-offload branch June 30, 2022 13:38
lhutton1 added a commit to lhutton1/tvm that referenced this pull request Jun 30, 2022
Follow up for apache#11469.

Change-Id: I474b1d43d3abc6b66d35ebcf3ad6fea50becfb97
lhutton1 added a commit to lhutton1/tvm that referenced this pull request Jul 5, 2022
Follow up for apache#11469.

Change-Id: I474b1d43d3abc6b66d35ebcf3ad6fea50becfb97
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
Fixes offloading a few corner cases of average pooling. Specifically
not offloading nn.avg_pool2d when:
* The attribute count_include_pad=True
* Padding exceeds the dimensions [3, 3, 4, 4]
* The pool size is greater than [8, 8] when the pool uses padding

Change-Id: I7be546e28ebe1f17482f3ed3cee56996a71bfcd1
manupak pushed a commit that referenced this pull request Jul 8, 2022
Follow up for #11469.

Change-Id: I474b1d43d3abc6b66d35ebcf3ad6fea50becfb97
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
Fixes offloading a few corner cases of average pooling. Specifically
not offloading nn.avg_pool2d when:
* The attribute count_include_pad=True
* Padding exceeds the dimensions [3, 3, 4, 4]
* The pool size is greater than [8, 8] when the pool uses padding

Change-Id: I7be546e28ebe1f17482f3ed3cee56996a71bfcd1
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
Follow up for apache#11469.

Change-Id: I474b1d43d3abc6b66d35ebcf3ad6fea50becfb97
junrushao pushed a commit to yelite/tvm that referenced this pull request Jul 27, 2022
Follow up for apache#11469.

Change-Id: I474b1d43d3abc6b66d35ebcf3ad6fea50becfb97
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Follow up for apache#11469.

Change-Id: I474b1d43d3abc6b66d35ebcf3ad6fea50becfb97
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Fixes offloading a few corner cases of average pooling. Specifically
not offloading nn.avg_pool2d when:
* The attribute count_include_pad=True
* Padding exceeds the dimensions [3, 3, 4, 4]
* The pool size is greater than [8, 8] when the pool uses padding

Change-Id: I7be546e28ebe1f17482f3ed3cee56996a71bfcd1
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Follow up for apache#11469.

Change-Id: I474b1d43d3abc6b66d35ebcf3ad6fea50becfb97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants