Silence unnecessary 'host' deprecation warnings#11499
Merged
jwfromm merged 1 commit intoapache:mainfrom May 28, 2022
Merged
Conversation
junrushao
approved these changes
May 27, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Nice work! Thank you for the swift fix!
Comment on lines
+262
to
+266
| if target_host is not None: | ||
| warnings.warn( | ||
| "target_host parameter is going to be deprecated. " | ||
| "Please pass in tvm.target.Target(target, host=target_host) instead." | ||
| ) |
There was a problem hiding this comment.
@mbs-octoml
In ConstantFold pass, target_host is always not None.(host is not None)
So warning message is printed on build time.
I think the above meg is not intended to warn the target which made in internal pass.
I am not perfectly understand canon_target_map_and_host,
So could you check this code block, when applied in constantFold pass.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out build_module.py will manufacture a host out of thin air, in which case the
warning is Target.canon_target_map_and_host is wrong headed.
Also make sure we only complain if the passed target host is actually used.