Skip to content

[python][docs] fix docstring typo#11608

Merged
comaniac merged 1 commit intoapache:mainfrom
cconvey:fix-typo
Jun 23, 2022
Merged

[python][docs] fix docstring typo#11608
comaniac merged 1 commit intoapache:mainfrom
cconvey:fix-typo

Conversation

@cconvey
Copy link
Contributor

@cconvey cconvey commented Jun 7, 2022

CC: @jcf94

Thanks @octoJon for pointing out the typo!

@@ -99,7 +99,7 @@ class XGBModel(PythonBasedModel):
model_file: Optional[str]
If is not None, save model to this file after every update.
adapative_training: bool = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one is also 'adapative' instead of 'adaptive'.

Copy link
Contributor

@octoJon octoJon Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, shoot, but the parameter name itself actually has the extra 'a'... Well, sorry for what I thought was just a comment fix which now looks like it requires fixing spelling within the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, shoot, but the parameter name itself actually has the extra 'a'... Well, sorry for what I thought was just a comment fix which now looks like it requires fixing spelling within the code.

Good catch! I'll update the PR to fix it everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated.

@cconvey
Copy link
Contributor Author

cconvey commented Jun 10, 2022

@comaniac @merrymercy: Mind giving this a review and (if okay) merge?

@cconvey
Copy link
Contributor Author

cconvey commented Jun 23, 2022

@comaniac @merrymercy: Would one of you mind giving this a review?

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit a6cbe0d into apache:main Jun 23, 2022
@comaniac
Copy link
Contributor

Thanks @cconvey @octoJon

blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants