[Bugfix][TIR] Narrow-Datatype for thread axis#11725
Merged
zxybazh merged 1 commit intoapache:mainfrom Jun 15, 2022
Merged
Conversation
This PR fixes a bug in the pass Narrow-Datatype in TIR, where dtype of certain IterVar and loop variables are adjusted to narrower ones. The bug occurs when the dtype of thread axis is int32, while its extent is int64, where the original behavior will not narrow the extent to int32, which causes an assertion thrown in IterVar's constructor. An alternative approach is to re-dtype IterVar to int64, however, the subsequent passes do not actually respect int64 thread axes, which leads to even more issues in lowering. This bug prevents AutoTIR in tuning Huggingface DistilBERT.
Hzfengsy
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the pass Narrow-Datatype in TIR, where dtype of
certain IterVar and loop variables are adjusted to narrower ones.
The bug occurs when the dtype of thread axis is int32, while its extent
is int64, where the original behavior will not narrow the extent to
int32, which causes an assertion thrown in IterVar's constructor. An
alternative approach is to re-dtype IterVar to int64, however, the
subsequent passes do not actually respect int64 thread axes, which leads
to even more issues in lowering.
This bug prevents AutoTIR in tuning Huggingface DistilBERT.