[Relay] Implement SoftmaxRel for softmax operators.#11728
Merged
masahi merged 2 commits intoapache:mainfrom Jun 16, 2022
wzh99:softmax-rel
Merged
[Relay] Implement SoftmaxRel for softmax operators.#11728masahi merged 2 commits intoapache:mainfrom wzh99:softmax-rel
SoftmaxRel for softmax operators.#11728masahi merged 2 commits intoapache:mainfrom
wzh99:softmax-rel
Conversation
ganler
reviewed
Jun 15, 2022
src/relay/op/nn/nn.cc
Outdated
| int ndim = static_cast<int>(data->shape.size()); | ||
| if (axis >= ndim || axis < -ndim) { | ||
| reporter->GetDiagCtx().EmitFatal(Diagnostic::Error(reporter->GetSpan()) | ||
| << "The axis is not in range [" << -ndim << ", " << ndim |
Contributor
There was a problem hiding this comment.
A better err msg should indicate the wrong axis. For example,
...
<< "Wrong axis (" << axis << ") not in expected range: [" << -ndim << ", " << ndim << ")";
Contributor
Author
There was a problem hiding this comment.
I have modified the error message as you suggest.
Contributor
|
Basically this PR lets Relay reject invalid softmax operator (axis >= rank) as earlier as the type inference phase (though such invalid cases will be rejected anyhow in later checks). @masahi Can you help decide if we want to merge this improvement? Thanks! |
masahi
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #11684. I replace
IdentityRelinnn.softmax,nn.fast_softmaxandnn.log_softmaxwith a newly implementedSoftmaxRelso that the attributeaxisis checked during type inference. For the test case shown in #11684, the following error is reported: