[LLVM/String] Remove conversion operator of String to llvm::StringRef#11807
Merged
kparzysz-quic merged 3 commits intoapache:mainfrom Jun 22, 2022
kparzysz-quic:string-no-stringref
Merged
[LLVM/String] Remove conversion operator of String to llvm::StringRef#11807kparzysz-quic merged 3 commits intoapache:mainfrom kparzysz-quic:string-no-stringref
kparzysz-quic merged 3 commits intoapache:mainfrom
kparzysz-quic:string-no-stringref
Conversation
added 3 commits
June 22, 2022 09:40
We should not be declaring LLVM data structures in headers unrelated to LLVM. There are only a handful of places where such a conversion was used, it was replaced with a more local solution.
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
…apache#11807) * [LLVM/String] Remove conversion operator of String to llvm::StringRef We should not be declaring LLVM data structures in headers unrelated to LLVM. There are only a handful of places where such a conversion was used, it was replaced with a more local solution. * Rebase to restart CI * Restart CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not be declaring LLVM data structures in headers unrelated to LLVM. There are only a handful of places where such a conversion was used, it was replaced with a more local solution.