Delete from __future__ import annotations since it requires Python …#11889
Merged
kparzysz-quic merged 1 commit intoapache:mainfrom Jun 24, 2022
kparzysz-quic:no-future-annotations
Merged
Delete from __future__ import annotations since it requires Python …#11889kparzysz-quic merged 1 commit intoapache:mainfrom kparzysz-quic:no-future-annotations
from __future__ import annotations since it requires Python …#11889kparzysz-quic merged 1 commit intoapache:mainfrom
kparzysz-quic:no-future-annotations
Conversation
zxybazh
approved these changes
Jun 24, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
LGTM. Thanks for reporting this issue!
Member
|
We should never include python 3.7 features in python 3.6. Just curious why the CI slipped it through :-( |
Contributor
Author
|
I think python 3.6.9 is the default on Ubuntu 18.04, so it would be a bit surprising the CI was using 3.7+. |
zxybazh
pushed a commit
to zxybazh/tvm
that referenced
this pull request
Jun 26, 2022
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…3.7+