Skip to content

[ETHOSN][CPP-RPC] Link NPU runtime in CPP RPC build#11946

Merged
leandron merged 1 commit intoapache:mainfrom
lhutton1:ethosn-cpp-rpc
Jun 30, 2022
Merged

[ETHOSN][CPP-RPC] Link NPU runtime in CPP RPC build#11946
leandron merged 1 commit intoapache:mainfrom
lhutton1:ethosn-cpp-rpc

Conversation

@lhutton1
Copy link
Contributor

When building the CPP RPC package with the NPU enabled, link_directories fails to find the NPU runtime libraries. This is presumably because the TVM runtime is linked with the PRIVATE option in: https://github.com/apache/tvm/blob/main/CMakeLists.txt#L601. Therefore working around this by following the precedent of other libraries such as Hexagon and Open CL.

cc @Leo-arm @manupa-arm

When building the CPP RPC package with the NPU enabled,
`link_directories` fails to find the NPU runtime libraries. This is
presumably because the TVM runtime is linked with the PRIVATE
option in: https://github.com/apache/tvm/blob/main/CMakeLists.txt#L601.
Therefore working around this by following the precedent of other
libraries such as Hexagon and Open CL.

Change-Id: Iba2fbc245df18147e3b564ba807ca78c9cc8461d
@github-actions github-actions bot requested a review from manupak June 29, 2022 12:55
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lhutton1!

@leandron leandron merged commit 1aec41a into apache:main Jun 30, 2022
@lhutton1 lhutton1 deleted the ethosn-cpp-rpc branch June 30, 2022 17:46
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
When building the CPP RPC package with the NPU enabled,
`link_directories` fails to find the NPU runtime libraries. This is
presumably because the TVM runtime is linked with the PRIVATE
option in: https://github.com/apache/tvm/blob/main/CMakeLists.txt#L601.
Therefore working around this by following the precedent of other
libraries such as Hexagon and Open CL.

Change-Id: Iba2fbc245df18147e3b564ba807ca78c9cc8461d
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
When building the CPP RPC package with the NPU enabled,
`link_directories` fails to find the NPU runtime libraries. This is
presumably because the TVM runtime is linked with the PRIVATE
option in: https://github.com/apache/tvm/blob/main/CMakeLists.txt#L601.
Therefore working around this by following the precedent of other
libraries such as Hexagon and Open CL.

Change-Id: Iba2fbc245df18147e3b564ba807ca78c9cc8461d
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
When building the CPP RPC package with the NPU enabled,
`link_directories` fails to find the NPU runtime libraries. This is
presumably because the TVM runtime is linked with the PRIVATE
option in: https://github.com/apache/tvm/blob/main/CMakeLists.txt#L601.
Therefore working around this by following the precedent of other
libraries such as Hexagon and Open CL.

Change-Id: Iba2fbc245df18147e3b564ba807ca78c9cc8461d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants