[VM] class Executable does not export symbols to dll#11963
Merged
tmoreau89 merged 2 commits intoapache:mainfrom Jun 30, 2022
Merged
[VM] class Executable does not export symbols to dll#11963tmoreau89 merged 2 commits intoapache:mainfrom
tmoreau89 merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Hello @tmoreau89! I observed new problem on my Windows machine after Alexey's fix, could you see this fix? After that fix the project is built on Windows. |
vvchernov
changed the title
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* class Executable of VM exports symbols to dll * restart CI Co-authored-by: Valery Chernov <valery.chernov@deelvin.com>
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* class Executable of VM exports symbols to dll * restart CI Co-authored-by: Valery Chernov <valery.chernov@deelvin.com>
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* class Executable of VM exports symbols to dll * restart CI Co-authored-by: Valery Chernov <valery.chernov@deelvin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It continues patch from #11947
When using the native C++ API of the
ExecutableofVirtual Machine, sometimes link error occurred when building the project:undefined symbols for the Executable.This is due to the fact that these symbols were not exported from
tvm.dll.This patch fixes this issue.