[Hexagon] Fix use of subprocess.run in _check_call_verbose#11985
Merged
kparzysz-quic merged 1 commit intoapache:mainfrom Jul 1, 2022
kparzysz-quic:check-call-verbose
Merged
[Hexagon] Fix use of subprocess.run in _check_call_verbose#11985kparzysz-quic merged 1 commit intoapache:mainfrom kparzysz-quic:check-call-verbose
kparzysz-quic merged 1 commit intoapache:mainfrom
kparzysz-quic:check-call-verbose
Conversation
It uses parameters that are not present in Python 3.6, plus it catches generic exception, which may not have `stdout` or `stderr` members.
kparzysz-quic
changed the title
_check_call_verbose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It uses parameters that are not present in Python 3.6, plus it catches generic exception, which may not have
stdoutorstderrmembers.cc @mehrdadh