Closed
Conversation
Author
|
@masahi This implementation still failed the test case with 1D input as the offsets are parsed into: which cannot be folded to constant at compile time even this 1D case is actually identical to 2D case: My take is that we can support 2D case here and see if there could be any workaround for the 1D cases like above. Note that |
added 4 commits
July 19, 2022 11:53
d9690c3 to
20eddfd
Compare
Author
|
closed with #12993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to add
aten::embedding_bagfor the pytorch frontend. Note that the implementation ofaten::numelis also changed under the condition that any input that can be evaluated to a constant value will be evaluated at compile time.Co-authored-by: Masahiro Masuda masahi@129@gmail.com
cc: @masahi @vinx13