[TIR] Fold const or empty iter partition#12080
Merged
kparzysz-quic merged 1 commit intoapache:mainfrom Jul 13, 2022
Merged
Conversation
Member
|
CC: @tqchen |
wrongtest-intellif
force-pushed
the
some_loop_partition_improvements
branch
from
e68870c to
9a3bec0
Compare
kparzysz-quic
approved these changes
Jul 13, 2022
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
wrongtest-intellif
added a commit
that referenced
this pull request
Aug 30, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor updation to loop partition pass
Use
tvm::min/tvm::maxinstead ofMin/MaxSince currently
VectorizeLooppass is just afterLoopPartition, there are no extra simplifications. The loop likeT.vectorize(Min(1, 8 - 3))will just fail on vectorizer check. We could just fold constants immediately when we create partitioned loops.Remove unneccesary warning log, and do not create zero-extent loop if we could prove the extent is less or equal to zero.