[ci][lint] Consolidate image lookup logic#12206
Merged
driazati merged 1 commit intoapache:mainfrom Jul 27, 2022
driazati:fix_fallback
Merged
[ci][lint] Consolidate image lookup logic#12206driazati merged 1 commit intoapache:mainfrom driazati:fix_fallback
driazati merged 1 commit intoapache:mainfrom
driazati:fix_fallback
Conversation
This makes `run_docker` just pass through the image name to `bash.sh` without preprocessing it at all so that `bash.sh` can do its own determination of which image to actually use.
areusch
approved these changes
Jul 27, 2022
Contributor
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This makes `run_docker` just pass through the image name to `bash.sh` without preprocessing it at all so that `bash.sh` can do its own determination of which image to actually use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
run_dockerjust pass through the image name tobash.shwithout preprocessing it at all so that
bash.shcan do its owndetermination of which image to actually use.
cc @Mousius @areusch