[CPP-RPC] Fix GetPath to use relative file path#12242
Merged
vinx13 merged 2 commits intoapache:mainfrom Aug 1, 2022
Merged
Conversation
Member
|
CC @FrozenGene who is the original author of CPP RPC |
FrozenGene
requested changes
Aug 1, 2022
FrozenGene
approved these changes
Aug 1, 2022
Member
|
Thanks @FrozenGene for taking time reviewing this PR! |
Contributor
Author
|
There is a flaky test |
Member
|
Thanks for reporting! I retriggered the CI |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [CPP-RPC] Fix GetPath to use relative file path * change file_path to file_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GetPath function can only use filenames as input, not relative paths.
Assuming the workpath is
/data/local/tmp/rpc, and when I useGetPath("dataset/img.jpg"), the expected result is/data/local/tmp/rpc/dataset/img.jpginstead ofdataset/img.jpg.