Skip to content

[Hexagon] Add skip option for RPC server initialization#12368

Merged
mehrdadh merged 4 commits intoapache:mainfrom
farshidsp:farshidsp/hexagon/add_parallelism
Aug 11, 2022
Merged

[Hexagon] Add skip option for RPC server initialization#12368
mehrdadh merged 4 commits intoapache:mainfrom
farshidsp:farshidsp/hexagon/add_parallelism

Conversation

@farshidsp
Copy link
Contributor

Adding flag to pytest to skip creating a new RPC server on the android device.

@mehrdadh

@mehrdadh mehrdadh changed the title Farshidsp/hexagon/add parallelism [Hexagon] Add skip option for RPC server initialization Aug 11, 2022
"--skip-rpc",
action="store_true",
default=False,
help="If set true, a new hexagon launcher is not created",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make it more clear by changing to this:
If set true, the RPC server initialization on Android would be skipped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @farshidsp!

@mehrdadh mehrdadh merged commit 48354de into apache:main Aug 11, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
* add hardware parallelism in hexagon

* fix name

* lint issue

* better description
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
* add hardware parallelism in hexagon

* fix name

* lint issue

* better description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants