[TIR] Expose TVM Backend API-related Builtins and Misc#12431
Closed
cyx-6 wants to merge 1 commit intoapache:mainfrom
Closed
[TIR] Expose TVM Backend API-related Builtins and Misc#12431cyx-6 wants to merge 1 commit intoapache:mainfrom
cyx-6 wants to merge 1 commit intoapache:mainfrom
Conversation
junrushao
changed the title
ops to python
junrushao
changed the title
leandron
requested changes
Aug 15, 2022
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
Hi @cyx-6 - thanks for the many PRs. I see that generally you're exposing TIR operators to Python so that TVMScript (which is described in an RFC). There are two things I'd like to improved in all there PRs:
- unit tests so that we can test the operations are actually accessible via Python
- a better commit message (currently set as update), that can be changed in the PR description. We would like to see the motivation for this change.
`op` list: `tvm_thread_allreduce` `tvm_access_ptr` `tvm_throw_last_error` `TVMBackendAllocWorkspace` `TVMBackendFreeWorkspace`
Member
|
See our discussion thread here. Let's do one PR at a time :-) |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oplist:tvm_thread_allreducetvm_access_ptrtvm_throw_last_errorTVMBackendAllocWorkspaceTVMBackendFreeWorkspaceUsed and tested for future TVMScript parser
Co-Authored-By: yongwww <55wuyong@163.com>
cc @junrushao1994