Use std::make_unique instead of std::unique_ptr(new ...), NFC#12459
Merged
kparzysz-quic merged 1 commit intoapache:mainfrom Aug 16, 2022
kparzysz-quic:make_unique
Merged
Use std::make_unique instead of std::unique_ptr(new ...), NFC#12459kparzysz-quic merged 1 commit intoapache:mainfrom kparzysz-quic:make_unique
kparzysz-quic merged 1 commit intoapache:mainfrom
kparzysz-quic:make_unique
Conversation
junrushao
approved these changes
Aug 16, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM. BTW, isnt std::make_unqiue<> C++14?
Contributor
Author
|
It is, but I guess we've never bothered to fix the pre-14 uses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.