[Hexagon][Runtime] Better support for 2-tier memory#12574
Merged
tmoreau89 merged 1 commit intoapache:mainfrom Sep 6, 2022
Merged
[Hexagon][Runtime] Better support for 2-tier memory#12574tmoreau89 merged 1 commit intoapache:mainfrom
tmoreau89 merged 1 commit intoapache:mainfrom
Conversation
cconvey
force-pushed
the
alloc-2tier
branch
6 times, most recently
from
3e8a668 to
aa3355b
Compare
Contributor
Author
|
@Lunderberg @csullivan @kparzysz-quic : Heads up, this should be ready for review once CI passes. |
cconvey
force-pushed
the
alloc-2tier
branch
2 times, most recently
from
a01b450 to
eba609d
Compare
Contributor
Author
|
@csullivan @Lunderberg @adstraw @kparzysz-quic: Looking at the CI results, I suspect there's a non-trivial issue with some existing code that uses "global" scope. PR won't be ready for review until I look into that. |
Contributor
Author
|
This might need fixing: |
cconvey
force-pushed
the
alloc-2tier
branch
4 times, most recently
from
e3d059d to
99346e4
Compare
- Introduce 'global.ddr' memory scope:
- Like 'global', this allocates memory from the Hexagon SoC's
DDR memory.
- Like 'global.vtcm', the specified tensor shape must be 1d
or 2d, where 2d indicates Hexagon's "indirect tensor"
(i.e., discontiguous) allocation scheme.
- Change memory-alignment strategy to always be 2048-byte aligned
on Hexagon. (This can be refined in the future, but for now it
ensures all allocations meet the strictest alignment requirements
for any Hexagon operations.)
Contributor
Author
I discussed this via DM with @csullivan. His impression is that having supporting |
Contributor
Author
|
@csullivan @jverma-quic : request for review |
nverke
approved these changes
Sep 2, 2022
Contributor
nverke
left a comment
nverke
left a comment
There was a problem hiding this comment.
I like this change! It might have saved me from a bug that was pushed to mainline a few days ago.
Ship it!
csullivan
approved these changes
Sep 2, 2022
| shape = tvm.testing.parameter((128, 128)) | ||
|
|
||
| (scope, axis_separators,) = tvm.testing.parameters( | ||
| ("global", []), |
Contributor
There was a problem hiding this comment.
nit: Could add an xfail test for ("global", [1]) to indicate this expectation explicitly.
cconvey
changed the title
adstraw
approved these changes
Sep 6, 2022
Contributor
adstraw
left a comment
adstraw
left a comment
There was a problem hiding this comment.
LGTM, thanks for the clarifying comments.
Contributor
|
Thank you @cconvey @csullivan @adstraw @nverke, the PR has been merged. |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
- Introduce 'global.ddr' memory scope:
- Like 'global', this allocates memory from the Hexagon SoC's
DDR memory.
- Like 'global.vtcm', the specified tensor shape must be 1d
or 2d, where 2d indicates Hexagon's "indirect tensor"
(i.e., discontiguous) allocation scheme.
- Change memory-alignment strategy to always be 2048-byte aligned
on Hexagon. (This can be refined in the future, but for now it
ensures all allocations meet the strictest alignment requirements
for any Hexagon operations.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[hexagon][runtime] better support for 2-tier memory
Introduce 'global.ddr' memory scope:
DDR memory.
or 2d, where 2d indicates Hexagon's "indirect tensor"
(i.e., discontiguous) allocation scheme.
Change memory-alignment strategy to always be 2048-byte aligned
on Hexagon. (This can be refined in the future, but for now it
ensures all allocations meet the strictest alignment requirements
for any Hexagon operations.)
cc @areusch @mehrdadh