Skip to content

[TIR] Fix pragma_loop_partition_hint attrs should check it's value#12699

Merged
Hzfengsy merged 1 commit intoapache:mainfrom
yincs-intellif:yincs
Sep 7, 2022
Merged

[TIR] Fix pragma_loop_partition_hint attrs should check it's value#12699
Hzfengsy merged 1 commit intoapache:mainfrom
yincs-intellif:yincs

Conversation

@yincs-intellif
Copy link
Contributor

@yincs-intellif yincs-intellif commented Sep 5, 2022

Current LoopPartition doesn't check the value of attribute key "pragma_loop_partition_hint". Whatever I set pragma_loop_partition_hint to True or False, the result is same, which is confused for debug.

This PR fix pragma_loop_partition_hint attribute key should check it's value.

@Hzfengsy

cc @junrushao1994

Copy link
Member

@Hzfengsy Hzfengsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yincs-intellif yincs-intellif force-pushed the yincs branch 3 times, most recently from 6c22293 to e2cfb44 Compare September 6, 2022 12:53
@Hzfengsy Hzfengsy merged commit 6cd31e7 into apache:main Sep 7, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…pache#12699)

Current LoopPartition doesn't check the value of attribute key "pragma_loop_partition_hint". Whatever I set pragma_loop_partition_hint to True or False, the result is same, which is confused for debug.

This PR fix pragma_loop_partition_hint attribute key should check it's value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants