[TIR][Fix] Handle iter vars in block predicate for SHash/SEqual#12724
Closed
Lunderberg wants to merge 1 commit intoapache:mainfrom
Closed
[TIR][Fix] Handle iter vars in block predicate for SHash/SEqual#12724Lunderberg wants to merge 1 commit intoapache:mainfrom
Lunderberg wants to merge 1 commit intoapache:mainfrom
Conversation
When lowering a non-opaque TIR block to an opaque block in `tir.transform.ConvertBlocksToOpaque`, the iter vars in `BlockNode::iter_vars` are replaced by their values in `BlockRealizeNode::iter_values` wherever they occur in `BlockRealize`. However, prior to this commit, the `BlockRealizeNode::predicate` was visited before the variable definition of `BlockNode::iter_vars`. As a result, StructuralHash and StructuralEqual would treat any occurrences as undefined variables, which is inconsistent with how they are handled in `ConvertBlocksToOpaque`. This commit resolves the inconsistency by changing the visit order such that `BlockRealizeNode::block` is visited before `BlockRealizeNode::predicate`.
Contributor
Author
|
Closing PR. From @vinx13 , it is not intended behavior for the predicate to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When lowering a non-opaque TIR block to an opaque block in
tir.transform.ConvertBlocksToOpaque, the iter vars in BlockNode::iter_varsare replaced by their values inBlockRealizeNode::iter_valueswherever they occur inBlockRealize. However, prior to this commit, theBlockRealizeNode::predicatewas visited before the variable definition ofBlockNode::iter_vars. As a result, StructuralHash and StructuralEqual would treat any occurrences as undefined variables, which is inconsistent with how they are handled inConvertBlocksToOpaque`.This commit resolves the inconsistency by changing the visit order such that
BlockRealizeNode::blockis visited beforeBlockRealizeNode::predicate.cc @Hzfengsy @junrushao1994