[ONNX] Upgrade onnx and onnxruntime#12729
Conversation
|
@tvm-bot rerun |
leandron
left a comment
There was a problem hiding this comment.
Thanks for the PR. Just a quick note that modifications in these scripts are not currently tested in CI, as the current CI workflow won't pickup the images created by a given PR to be effectively used to run the tests on that CI run.
There is ongoing work by @driazati to make that happen, but we're not there yet.
In the meantime I'd like to understand what is the motivation for the update?
Thanks for the quick comment. A couple of reasons... It's been a while since we updated onnx version in TVM and I'd like to understand the gap in the onnx frontend (given opset 17 is available now). I'd also like to add some onnx models to CI for model testing, and onnx model hub is available 1.11.0+. What would be the best way to update CI images and run tests in this case? cc @driazati |
|
Currently there's no good solution outside of running things locally, in the past for these kinds of changes it's been more of a merge it first, build new Docker images, then test the changes when trying to update the Docker images to the new ones. I will dust off #11893 today and try to get it merged, then that'll test everything in 1 PR before merging. |
It is required as some work was recently done to enable Integration Tests that use onnx on |
|
@tvm-bot rerun |
fab4289 to
628b3b5
Compare
|
@tvm-bot rerun |
|
@driazati @leandron @AndrewZhaoLuo please review |
|
I'm seeing one test failing on GPU machines with some ONNX message, with Docker images to contain this update. Can you have a look? https://ci.tlcpack.ai/job/docker-images-ci/job/docker-image-run-tests/231/testReport/junit/cython.tests.python.frontend.onnx/test_forward/Test___frontend__GPU_3_of_6___test_roi_align_cuda_/ |
Upgrade onnx and onnxruntime to latest
Upgrade onnx and onnxruntime to latest