[ci] Don't rerun segfaulting failures#12850
Closed
driazati wants to merge 1 commit intoapache:mainfrom
driazati:segfault_reporting
Closed
[ci] Don't rerun segfaulting failures#12850driazati wants to merge 1 commit intoapache:mainfrom driazati:segfault_reporting
driazati wants to merge 1 commit intoapache:mainfrom
driazati:segfault_reporting
Conversation
Contributor
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
This is a less-than-ideal fix for #12776. It disables reruns for crashes in xdist workers, which gets rid of the pytest internal failure and correctly reports the test name. Ideally it would also include the backtrace in the report and rerun the test but there doesn't seem to be an easy way to get pytest-rerunfailures to do that alongside the LoadScopeScheduler.
areusch
added
needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a less-than-ideal fix for #12776. It disables reruns for crashes
in xdist workers, which gets rid of the pytest internal failure and
correctly reports the test name. Ideally it would also include the
backtrace in the report and rerun the test but there doesn't seem to be
an easy way to get pytest-rerunfailures to do that alongside the
LoadScopeScheduler since the latter doesn't have a way to re-queue
tests.