[IR] Use TVM_DEFINE_OBJECT_REF_METHODS macro for Op#12893
Merged
junrushao merged 1 commit intoapache:mainfrom Sep 24, 2022
Merged
[IR] Use TVM_DEFINE_OBJECT_REF_METHODS macro for Op#12893junrushao merged 1 commit intoapache:mainfrom
junrushao merged 1 commit intoapache:mainfrom
Conversation
Previously, the `get()` method wasn't defined, and returned a `RelayExprNode` instead of a `Op::ContainerType*`.
junrushao
approved these changes
Sep 23, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM! Not sure why we were not using that previously but definitely it's a positive improvement
Contributor
Author
|
If I had to guess, that would be based more on implementation timing than anything else. The |
Member
|
Ah ancient history! |
Member
|
It should be ready for merge :-) |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Previously, the `get()` method wasn't defined, and returned a `RelayExprNode` instead of a `Op::ContainerType*`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
get()method wasn't defined, and returned aRelayExprNodeinstead of aOp::ContainerType*.