[TIR] Remove unused iters from the result of reindex#12946
Merged
junrushao merged 1 commit intoapache:mainfrom Sep 30, 2022
Merged
[TIR] Remove unused iters from the result of reindex#12946junrushao merged 1 commit intoapache:mainfrom
junrushao merged 1 commit intoapache:mainfrom
Conversation
vinx13
force-pushed
the
feat/reindex-no-unused
branch
from
085bd03 to
77581ba
Compare
github-actions
bot
requested review from
Hzfengsy,
junrushao and
spectrometerHBH
Member
|
I’m not sure though if it’s going to affect tuning or not, because MetaSchedule relies on the structural stability of TIR so that its analysis outcome doesn’t change much. Would you like to elaborate? Thanks a lot! |
Member
Author
|
it doesn't because the result is consistent. it only affects im2col results, which is one of the preprocessing step before MultiLevelTiling |
vinx13
force-pushed
the
feat/reindex-no-unused
branch
from
77581ba to
9329868
Compare
vinx13
force-pushed
the
feat/reindex-no-unused
branch
from
9329868 to
02f1596
Compare
Hzfengsy
approved these changes
Sep 30, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
The existence of unused block iters make it difficult for block layout transformation. Previous it relies the flag `simplify_trivial_iter=true` in affine analysis, which is unsafe because simplifying trivial iterators during scheduling stage lose the information of iterators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existence of unused block iters make it difficult for block layout transformation. Previous it relies the flag
simplify_trivial_iter=truein affine analysis, which is unsafe because simplifying trivial iterators during scheduling stage lose the information of iterators.cc @spectrometerHBH @junrushao @Hzfengsy