[CODEGEN][OPENCL] Sampler definition should be at outermost scope#12951
Merged
masahi merged 1 commit intoapache:mainfrom Oct 5, 2022
Merged
[CODEGEN][OPENCL] Sampler definition should be at outermost scope#12951masahi merged 1 commit intoapache:mainfrom
masahi merged 1 commit intoapache:mainfrom
Conversation
Not all OpenCL compiers happy with inline sample definitions. Specification: "The image read functions take a sampler argument. The sampler can be passed as an argument to the kernel using clSetKernelArg, or can be declared in the outermost scope of kernel functions, or it can be a constant variable of type sampler_t declared in the program source."
echuraev
approved these changes
Sep 30, 2022
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
Thaks! In general LGTM. One minor question.
| for (Var arg : f->params) { | ||
| auto ptr_type = arg->type_annotation.as<PointerTypeNode>(); | ||
| if (ptr_type && runtime::IsTextureStorage(std::string(ptr_type->storage_scope))) { | ||
| this->stream << " const sampler_t image_sampler = " |
Contributor
There was a problem hiding this comment.
nit: Will we create this variable before function body in global scope?
If yes, then why we need this indent before const sampler_t ...?
I suppose it should be something like that:
const sampler_t image_sampler = "CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_CLAMP | CLK_FILTER_NEAREST;\n";
__kernel void kernel_name(..) {
// ...
}
Am I right?
Contributor
Author
There was a problem hiding this comment.
Its the first line of function body.
__kernel void kernel_name(..) {
const sampler_t image_sampler = "CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_CLAMP | CLK_FILTER_NEAREST;
// ...
}
Contributor
There was a problem hiding this comment.
Ok, thank you for the clarification! LGTM.
echuraev
approved these changes
Sep 30, 2022
Contributor
|
cc: @masahi |
masahi
approved these changes
Oct 5, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…ache#12951) Not all OpenCL compiers happy with inline sample definitions. Specification: "The image read functions take a sampler argument. The sampler can be passed as an argument to the kernel using clSetKernelArg, or can be declared in the outermost scope of kernel functions, or it can be a constant variable of type sampler_t declared in the program source."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all OpenCL compiers happy with inline sampler definition.
Specification: "The image read functions take a sampler argument. The sampler can be passed as an argument to the kernel using clSetKernelArg, or can be declared in the outermost scope of kernel functions, or it can be a constant variable of type sampler_t declared in the program source."