Skip to content

[Hexagon] [runtime] Query for total and available VTCM #12992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driazati merged 3 commits into from
Oct 6, 2022
Merged

[Hexagon] [runtime] Query for total and available VTCM #12992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d7dc91
Query for total and available VTCM
janetsc Oct 5, 2022
39a3018
Fix lint, comments
janetsc Oct 5, 2022
84153e0
Check for at least 1MB VTCM
janetsc Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/runtime/hexagon/hexagon_vtcm_pool.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,23 +29,30 @@ HexagonVtcmPool::HexagonVtcmPool() {
compute_res_attr_t res_info;
HEXAGON_SAFE_CALL(HAP_compute_res_attr_init(&res_info));

// TODO(HWE): get the max and min size programmatically
const unsigned int max_size = 4 * 1024 * 1024;
const unsigned int min_size = 1024 * 1024;
unsigned int total_block_size;
unsigned int avail_block_size;
compute_res_vtcm_page_t total_block_layout;
compute_res_vtcm_page_t avail_block_layout;

HEXAGON_SAFE_CALL(compute_resource_query_VTCM(/* application_id = */ 0, &total_block_size,
&total_block_layout, &avail_block_size,
&avail_block_layout));
DLOG(INFO) << "HexagonVtcmPool total " << total_block_size << " avail " << avail_block_size;
CHECK(avail_block_size >= (1024 * 1024)) << "Less than 1MB VTCM available";

// allocate nbytes of vtcm on a single page
HEXAGON_SAFE_CALL(HAP_compute_res_attr_set_vtcm_param_v2(&res_info,
/*vtcm_size = */ max_size,
/*vtcm_size = */ total_block_size,
/*min_page_size = */ 1,
/*min_vtcm_size = */ min_size));
/*min_vtcm_size = */ avail_block_size));

// TODO(HWE): Investigate why a non-zero timeout results in
// hanging, both in the simulator and on hardware.
context_id_ = HAP_compute_res_acquire(&res_info, /*timeout = */ 0);
CHECK(context_id_) << "HAP_compute_res_acquire failed to acquire requested VTCM resource.";
HEXAGON_SAFE_CALL(HAP_compute_res_attr_get_vtcm_ptr_v2(&res_info, &vtcm_data_, &vtcm_size_));
CHECK(vtcm_data_ != nullptr) << "HAP_compute_res_acquire returned nullptr when allocating VTCM.";
CHECK(vtcm_size_ >= min_size)
CHECK(vtcm_size_ >= avail_block_size)
<< "HAP_compute_res_acquire failed to allocate minimum amount of VTCM";
free_.emplace_back(std::pair<char*, size_t>(static_cast<char*>(vtcm_data_), vtcm_size_));
// DebugDump();
Expand Down
4 changes: 2 additions & 2 deletions src/runtime/hexagon/hexagon_vtcm_pool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ class HexagonVtcmPool {
size_t TotalBytes() { return reinterpret_cast<size_t>(vtcm_size_); }

private:
//! \brief Context for HAP_compute_res_*
//! \brief Total size of VTCM pool
unsigned int vtcm_size_;

//! \brief Context for HAP_compute_res_*
//! \brief Pointer to the beginning of the pool
void* vtcm_data_;

//! \brief Context for HAP_compute_res_*
Expand Down