Skip to content

Mingw support#13017

Closed
TSCCompiler wants to merge 53 commits intoapache:mainfrom
TSCCompiler:mingw_support
Closed

Mingw support#13017
TSCCompiler wants to merge 53 commits intoapache:mainfrom
TSCCompiler:mingw_support

Conversation

@TSCCompiler
Copy link
Copy Markdown

Add support for MinGW compiler on windows platform, so You can use std c++17 or LLVM higher version(13.x ...) without upgrade MSVC compilers, It's also easy to deploy on windows platform

sunhh and others added 30 commits September 20, 2022 19:23
add ${TVM_RUNTIME_LINKER_LIBS} in tvm_rpc
load from relay ir
tune torch models using pickle mod and binary params
infer face images with different input name
export relay from onnx
add export from paddlepaddle
use pickle relay mod
export arm opencl
export paddle ocr rec
export to desired folder
goon tune when break
add rk3588 opencl support
add script to start tracker and query
add _opt for optimised export
@junrushao
Copy link
Copy Markdown
Member

This is indeed an interesting change and it would be great if we could get this in. On the other hand, I would love to see the PR being organized a bit more :-)

@TSCCompiler
Copy link
Copy Markdown
Author

Thank you! I 've already fixed conflicts I will learning how to make a better PR

sunhh added 2 commits October 10, 2022 10:00
…r to compile ptx code

remove debug log
add --Wl,--exclude-all-symbols only in mingw compiler
@junrushao
Copy link
Copy Markdown
Member

Thank you so much! I'm happy to shepherd this PR :-)

.gitignore Outdated
Comment on lines +271 to +274
/python/images/
/python/models/
/python/depoly/
/python/build/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines may not be relevant - let's get them removed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@junrushao
Copy link
Copy Markdown
Member

Generally speaking, there are couple of rules we might want to follow to draft a PR:

  • Do not include unnecessary change to 3rdparty dependency, if not relevant in the PR;
  • Do not include debug printing
  • Do not include code that's been commented out

Let's polish the code quality and get it in ASAP :-)

CMakeLists.txt Outdated
Comment on lines +4 to +5
MESSAGE(STATUS "c compiler : ${CMAKE_COMPILER_IS_GNUCC}")
message(STATUS "system name : ${CMAKE_SYSTEM_NAME}")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! just wanted to point out that we have Summary.cmake: https://github.com/apache/tvm/blob/main/cmake/utils/Summary.cmake#L47 (which you can enable with -DSUMMARIZE=1 or set(SUMMARIZE ON) in config.cmake), so these info messages could be moved there

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok ,I will move it there

@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
@masahi
Copy link
Copy Markdown
Member

masahi commented Dec 8, 2022

Please continue in #13079

@masahi masahi closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants