[FIX,LOWERING] Add attrs from Relay Functions to PrimFuncs in Metaschedule Lowering#13034
Merged
tkonolige merged 1 commit intoapache:mainfrom Oct 11, 2022
Merged
Conversation
…edule Lowering Attrs were not propogated from Relay functions to the corresponding PrimFunc when lowering with MetaSchedule enabled. These attrs are not seperately copied in the MetaSchedule lowering flow.
tkonolige
force-pushed
the
fix_labelops_metaschedule
branch
from
2596b8f to
144af83
Compare
junrushao
approved these changes
Oct 11, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM. Is there any specific attribute in your mind that needs cross-IR propagation? hash?
Contributor
Author
|
Hash is the most important one, but layout information is also useful. |
Member
|
Does Relay do any follow-up layout optimization after being lowered to TIR? |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…edule Lowering (apache#13034) Attrs were not propogated from Relay functions to the corresponding PrimFunc when lowering with MetaSchedule enabled. These attrs are not seperately copied in the MetaSchedule lowering flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attrs were not propogated from Relay functions to the corresponding PrimFunc when lowering with MetaSchedule enabled. These attrs are not seperately copied in the MetaSchedule lowering flow.
@junrushao