[Hexagon] [runtime] Remove released buffer check for post-ReleaseResources calls to FreeDataSpace#13139
Merged
masahi merged 2 commits intoapache:mainfrom Oct 19, 2022
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
adstraw
suggested changes
Oct 19, 2022
adstraw
approved these changes
Oct 19, 2022
masahi
approved these changes
Oct 19, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
…urces calls to FreeDataSpace (apache#13139) * Remove released buffer list * PR feedback, make message debug only
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…urces calls to FreeDataSpace (apache#13139) * Remove released buffer list * PR feedback, make message debug only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation behind resource management is to ensure that we release all resources at the end of the session.
Given the session management on the client side, it is possible for ReleaseResources to be called before all client side objects have been torn down. And, it is possible for frees to be called in the window between session end and process termination. (After those buffers have been freed in ReleaseResources.)
Based on feedback from @adstraw and @Lunderberg on the usage of "released_runtime_buffers," we did an investigation into the post-release frees. The cleanest solution is to keep the logic to free all buffers in ReleaseResources, and log a message on any frees that are executed outside a session.