[Hexagon] Adjust Hexagon pytest port range#13172
Merged
mehrdadh merged 1 commit intoapache:mainfrom Oct 21, 2022
Merged
Conversation
ADB, the Android Debug Bridge, tries to determine if an emulator is present by looking for port 5555 being open. Unfortunately, once adb thinks there's an emulator running, it will continously try to connect to it, adding an error to its log on every failed attempt. This log file quickly grows to hundreds of gigabytes before developers notice they are completely out of disk space. This problem is further compounded by the Hexagon Launcher forwarding 10 contiguous ports from the randomly-chosen RPC base port, causing this failure to happen more often than you'd otherwise suspect. See https://stackoverflow.com/questions/3152681/android-emulator-5554-offline/10356594#10356594
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
mehrdadh
approved these changes
Oct 21, 2022
Member
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
great catch! thanks for the fix!
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
Adjust Hexagon pytest port range ADB, the Android Debug Bridge, tries to determine if an emulator is present by looking for port 5555 being open. Unfortunately, once adb thinks there's an emulator running, it will continously try to connect to it, adding an error to its log on every failed attempt. This log file quickly grows to hundreds of gigabytes before developers notice they are completely out of disk space. This problem is further compounded by the Hexagon Launcher forwarding 10 contiguous ports from the randomly-chosen RPC base port, causing this failure to happen more often than you'd otherwise suspect. See https://stackoverflow.com/questions/3152681/android-emulator-5554-offline/10356594#10356594
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Adjust Hexagon pytest port range ADB, the Android Debug Bridge, tries to determine if an emulator is present by looking for port 5555 being open. Unfortunately, once adb thinks there's an emulator running, it will continously try to connect to it, adding an error to its log on every failed attempt. This log file quickly grows to hundreds of gigabytes before developers notice they are completely out of disk space. This problem is further compounded by the Hexagon Launcher forwarding 10 contiguous ports from the randomly-chosen RPC base port, causing this failure to happen more often than you'd otherwise suspect. See https://stackoverflow.com/questions/3152681/android-emulator-5554-offline/10356594#10356594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADB, the Android Debug Bridge, tries to determine if an emulator is present by looking for port 5555 being open. Unfortunately, once adb thinks there's an emulator running, it will continously try to connect to it, adding an error to its log on every failed attempt. This log file quickly grows to hundreds of gigabytes before developers notice they are completely out of disk space. This problem is further compounded by the Hexagon Launcher forwarding 10 contiguous ports from the randomly-chosen RPC base port, causing this failure to happen more often than you'd otherwise suspect.
See https://stackoverflow.com/questions/3152681/android-emulator-5554-offline/10356594#10356594
cc: @csullivan @mehrdadh @cconvey