[Hexagon] [runtime] Allow creation of thread manager without hardware resources#13174
Merged
driazati merged 4 commits intoapache:mainfrom Oct 21, 2022
Merged
[Hexagon] [runtime] Allow creation of thread manager without hardware resources#13174driazati merged 4 commits intoapache:mainfrom
driazati merged 4 commits intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
adstraw
reviewed
Oct 21, 2022
| ASSERT_THROW(HexagonThreadManager(6, stack_size, 0x10000000), InternalError); | ||
| // hw resources count doesn't match thread count | ||
| ASSERT_THROW(HexagonThreadManager(6, stack_size, pipe_size, {DMA_0}), InternalError); | ||
| // hw resources doesn't match specific supported configuration |
Contributor
There was a problem hiding this comment.
We should come back and revisit this. Having this very strict specification of hardware resources is probably not what we want long term. Let's see if we can make this a little more flexible going forward. That said, I am OK with this PR as an interim step.
adstraw
approved these changes
Oct 21, 2022
driazati
approved these changes
Oct 21, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
… resources (apache#13174) This allows the creation of a thread manager with optional hardware resources. This allows us to create a new object for unit tests without hardware resources. This will fix the test instability we've seen recently, as all tests were using the global thread manager and things could be in an unknown state.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
… resources (apache#13174) This allows the creation of a thread manager with optional hardware resources. This allows us to create a new object for unit tests without hardware resources. This will fix the test instability we've seen recently, as all tests were using the global thread manager and things could be in an unknown state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the creation of a thread manager with optional hardware resources. This allows us to create a new object for unit tests without hardware resources.
This will fix the test instability we've seen recently, as all tests were using the global thread manager and things could be in an unknown state.
cc: @adstraw, @mehrdadh, @JosephTheOctonaut, @csullivan