Fixup libtorch backend build#13320
Merged
junrushao merged 1 commit intoapache:mainfrom Nov 8, 2022
leiwen83:libtorch_fixup
Merged
Fixup libtorch backend build#13320junrushao merged 1 commit intoapache:mainfrom leiwen83:libtorch_fixup
junrushao merged 1 commit intoapache:mainfrom
leiwen83:libtorch_fixup
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
shingjan
approved these changes
Nov 8, 2022
shingjan
left a comment
shingjan
left a comment
There was a problem hiding this comment.
LGTM. Could there be more context on the dlpack mismatch between PyTorch and TVM. Thanks!
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
Add clang-format disable for header to prevent reorder. Torch header file need to be put at the end since torch's dlpack is a little different with tvm's. Signed-off-by: Lei Wen <wenlei03@qiyi.com> Co-authored-by: Lei Wen <wenlei03@qiyi.com>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Add clang-format disable for header to prevent reorder. Torch header file need to be put at the end since torch's dlpack is a little different with tvm's. Signed-off-by: Lei Wen <wenlei03@qiyi.com> Co-authored-by: Lei Wen <wenlei03@qiyi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add clang-format disable for header to prevent reorder. Torch header file need to be put at the end since torch's dlpack is a little different with tvm's.
cc @t-vi @masahi
Signed-off-by: Lei Wen wenlei03@qiyi.com